[ 
https://issues.apache.org/jira/browse/AMQ-9646?focusedWorklogId=953999&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-953999
 ]

ASF GitHub Bot logged work on AMQ-9646:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Jan/25 00:13
            Start Date: 24/Jan/25 00:13
    Worklog Time Spent: 10m 
      Work Description: cshannon commented on code in PR #1377:
URL: https://github.com/apache/activemq/pull/1377#discussion_r1927911075


##########
activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/KahaDBStore.java:
##########
@@ -766,6 +773,83 @@ public void execute(Transaction tx) throws Exception {
                             }
                         }
                         sd.orderIndex.stoppedIterating();
+
+                        if(revertOrderIndex && position > 0) {
+                            sd.orderIndex.resetCursorPosition();

Review Comment:
   This does not revert the index to the previous location, it reverts it to 0 
at the beginning. One way to avoid having side effects and having to reset at 
all is to create a different MessageOrderCursor and not the internal one as 
that tracks state.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 953999)
    Time Spent: 1h 10m  (was: 1h)

> Support selecting specific messages for command line backup
> -----------------------------------------------------------
>
>                 Key: AMQ-9646
>                 URL: https://issues.apache.org/jira/browse/AMQ-9646
>             Project: ActiveMQ Classic
>          Issue Type: Improvement
>            Reporter: Matt Pavlovich
>            Assignee: Matt Pavlovich
>            Priority: Minor
>             Fix For: 6.2.0, 5.19.0
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to