[
https://issues.apache.org/jira/browse/AMQ-9646?focusedWorklogId=953991&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-953991
]
ASF GitHub Bot logged work on AMQ-9646:
---------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jan/25 23:55
Start Date: 23/Jan/25 23:55
Worklog Time Spent: 10m
Work Description: cshannon commented on code in PR #1377:
URL: https://github.com/apache/activemq/pull/1377#discussion_r1927854541
##########
activemq-console/src/main/java/org/apache/activemq/console/command/store/StoreBackup.java:
##########
@@ -88,6 +97,14 @@ public void execute() throws Exception {
throw new Exception("optional --offset and --count must be
specified together");
}
+ if ((startMsgId != null || endMsgId != null) && queue == null) {
+ throw new Exception("optional --queue must be specified when using
startMsgId or endMsgId");
+ }
+
+ if (indexes != null && !indexes.isBlank()) {
+ indexesList = parseIndexesParam(indexes);
Review Comment:
```suggestion
ndexesList = Stream.of(indexes.split(",")).map(index ->
Integer.parseInt(index.trim())).collect(Collectors.toList());
```
##########
activemq-console/src/main/java/org/apache/activemq/console/command/store/StoreBackup.java:
##########
@@ -88,6 +97,14 @@ public void execute() throws Exception {
throw new Exception("optional --offset and --count must be
specified together");
}
+ if ((startMsgId != null || endMsgId != null) && queue == null) {
+ throw new Exception("optional --queue must be specified when using
startMsgId or endMsgId");
+ }
+
+ if (indexes != null && !indexes.isBlank()) {
+ indexesList = parseIndexesParam(indexes);
Review Comment:
```suggestion
indexesList = Stream.of(indexes.split(",")).map(index ->
Integer.parseInt(index.trim())).collect(Collectors.toList());
```
Issue Time Tracking
-------------------
Worklog Id: (was: 953991)
Time Spent: 1h (was: 50m)
> Support selecting specific messages for command line backup
> -----------------------------------------------------------
>
> Key: AMQ-9646
> URL: https://issues.apache.org/jira/browse/AMQ-9646
> Project: ActiveMQ Classic
> Issue Type: Improvement
> Reporter: Matt Pavlovich
> Assignee: Matt Pavlovich
> Priority: Minor
> Fix For: 6.2.0, 5.19.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
