[
https://issues.apache.org/jira/browse/AMQCPP-756?focusedWorklogId=959576&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-959576
]
ASF GitHub Bot logged work on AMQCPP-756:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/25 19:30
Start Date: 01/Mar/25 19:30
Worklog Time Spent: 10m
Work Description: artnaseef commented on PR #21:
URL: https://github.com/apache/activemq-cpp/pull/21#issuecomment-2692377947
I am trying with the configure script - appears to be working. The
`build.sh` script is confusing as the README.txt's instructions just say:
> The easiest
way to enable this is to edit the build.conf file before running build.sh,
which will create an appropriate configure script and run it. Then, simply
'cd build' before running make or the tests.
This is bringing back memories. Long lost memories ;-). Haven't had to
deal with complicated instructions like this in a long time... Can we update
the `configure.ac` like this?
*OLD*
```
if test "$GCC" = "yes"; then
PLAT_CXXFLAGS="-ansi -pedantic"
fi
```
*NEW*
```
if test "$GCC" = "yes"; then
PLAT_CXXFLAGS="-std=c++17"
fi
```
My hope is we can get as close as possible to `./configure` then `make` just
working out of the box.
Issue Time Tracking
-------------------
Worklog Id: (was: 959576)
Time Spent: 1.5h (was: 1h 20m)
> Upgrade for C++17 compliance
> ----------------------------
>
> Key: AMQCPP-756
> URL: https://issues.apache.org/jira/browse/AMQCPP-756
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Components: CMS Impl
> Affects Versions: 3.9.4, 3.9.5
> Environment: Linux Ubuntu 22.04
> GCC 11.4.0
> OpenSSL 1.1.0
> Cppunit 1.15.1
> Reporter: Arjun Ray
> Assignee: Timothy A. Bish
> Priority: Major
> Fix For: 3.9.5
>
> Attachments: fixautoptr-1.diff, fixerrs-1.diff, fixinits-1.diff,
> fixwarns-1.diff
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Changes covered:
> # Global replacement of std::auto_ptr with std::unique_ptr.
> # 6 fixups for this change (5 initializers, 1 missing include file).
> # Compiling with GCC 11.4.0 yields
> ## 1 error from 'make' and 5 errors from 'make check'
> ## 197 warnings from 'make' and 35 from 'make check'.
> # 6 + 38 files modified to eliminate these issues. No change in user-facing
> APIs.
> # All tests pass (2070 regular, 133 integration).
> Odds and ends:
> # Temporary script added to make up for missing cppunit-config (obsolete and
> removed from distributions).
> # More generally, the m4 macros used to configure the build are badly out of
> date and need to be upgraded (at which point the script above can be removed).
> # Global replacement of 'throw()' with 'noexcept' is advisable, as the
> 'throw()' alias has been removed in C++20.
> # OpenSSL version >= 1.1.0
> This Jira is to label the set of changes properly in a pull request to be
> submitted in Github. Files will also be available in a 'forked' version on
> Github at [https://github.com/arayq2/activemq-cpp.]
>
> 4 attachments;
> # Patch for eliminating redundant initializers (fixinits.diff).
> # Patch for global replacement of auto_ptr (fixautoptr.diff).
> # Patch for fixing errors from C++17 compilation (fixerrs.diff).
> # Patch for fixing warnings from C++17 compilation (fixwarns.diff)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
