[
https://issues.apache.org/jira/browse/AMQCPP-756?focusedWorklogId=959595&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-959595
]
ASF GitHub Bot logged work on AMQCPP-756:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/25 20:13
Start Date: 01/Mar/25 20:13
Worklog Time Spent: 10m
Work Description: arayq2 commented on PR #21:
URL: https://github.com/apache/activemq-cpp/pull/21#issuecomment-2692395638
I've been looking at these various config and build related files, and I
agree that they need work. For example, I've checked the two README files and
determined that the one at the distro root is obsolete. We should probably nuke
it lest it cause confusion, and convert the other one to .md format.
There's stuff in configure.ac that looks iffy, such as the PLAT_CXXFLAGS
setting for GCC outside the case statement. (Does that mean that GCC is not
used at all on those platforms?) I think it should be removed as well.
And then there is the business of cppunit-config being obsolete and missing
on modern systems. pkg-config is neither a drop-in replacement, nor is it
universal (I believe it is Debian/Ubuntu specific). My shell script is a
terrible hack but right no i can't think of a good way to automate that part.
Issue Time Tracking
-------------------
Worklog Id: (was: 959595)
Time Spent: 2h 10m (was: 2h)
> Upgrade for C++17 compliance
> ----------------------------
>
> Key: AMQCPP-756
> URL: https://issues.apache.org/jira/browse/AMQCPP-756
> Project: ActiveMQ C++ Client
> Issue Type: Improvement
> Components: CMS Impl
> Affects Versions: 3.9.4, 3.9.5
> Environment: Linux Ubuntu 22.04
> GCC 11.4.0
> OpenSSL 1.1.0
> Cppunit 1.15.1
> Reporter: Arjun Ray
> Assignee: Timothy A. Bish
> Priority: Major
> Fix For: 3.9.5
>
> Attachments: fixautoptr-1.diff, fixerrs-1.diff, fixinits-1.diff,
> fixwarns-1.diff
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Changes covered:
> # Global replacement of std::auto_ptr with std::unique_ptr.
> # 6 fixups for this change (5 initializers, 1 missing include file).
> # Compiling with GCC 11.4.0 yields
> ## 1 error from 'make' and 5 errors from 'make check'
> ## 197 warnings from 'make' and 35 from 'make check'.
> # 6 + 38 files modified to eliminate these issues. No change in user-facing
> APIs.
> # All tests pass (2070 regular, 133 integration).
> Odds and ends:
> # Temporary script added to make up for missing cppunit-config (obsolete and
> removed from distributions).
> # More generally, the m4 macros used to configure the build are badly out of
> date and need to be upgraded (at which point the script above can be removed).
> # Global replacement of 'throw()' with 'noexcept' is advisable, as the
> 'throw()' alias has been removed in C++20.
> # OpenSSL version >= 1.1.0
> This Jira is to label the set of changes properly in a pull request to be
> submitted in Github. Files will also be available in a 'forked' version on
> Github at [https://github.com/arayq2/activemq-cpp.]
>
> 4 attachments;
> # Patch for eliminating redundant initializers (fixinits.diff).
> # Patch for global replacement of auto_ptr (fixautoptr.diff).
> # Patch for fixing errors from C++17 compilation (fixerrs.diff).
> # Patch for fixing warnings from C++17 compilation (fixwarns.diff)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
