[
https://issues.apache.org/jira/browse/ARTEMIS-5775?focusedWorklogId=992902&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-992902
]
ASF GitHub Bot logged work on ARTEMIS-5775:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Nov/25 22:47
Start Date: 21/Nov/25 22:47
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #6083:
URL: https://github.com/apache/activemq-artemis/pull/6083#discussion_r2551127452
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java:
##########
@@ -706,33 +707,17 @@ private RoutingType
getRoutingTypeFromAddress(SimpleString address) {
return RoutingType.MULTICAST;
}
- private boolean requireNullResponseMessage_V1(Packet packet) {
- return channel.getConnection().isVersionBeforeAsyncResponseChange();
- }
-
- private NullResponseMessage createNullResponseMessage_V1(Packet packet) {
- assert requireNullResponseMessage_V1(packet);
- return poolNullResponse.borrow();
- }
-
- private NullResponseMessage_V2 createNullResponseMessage_V2(Packet packet) {
- assert !requireNullResponseMessage_V1(packet);
- NullResponseMessage_V2 response;
- response = poolNullResponseV2.borrow();
+ private Packet createNullResponseMessage(Packet packet) {
+ NullResponseMessage response = poolNullResponse.borrow();
// this should be already set by the channel too, but let's do it just
in case
- response.setCorrelationID(packet.getCorrelationID());
+ if (response instanceof NullResponseMessage_V2 v2) {
Review Comment:
I'm not an expert on Core protocol handling but I wonder if you could add a
no-op version of the setCorrelationID to the base NullResponseMessage such that
each create call doesn't need to do this instanceof check?
Issue Time Tracking
-------------------
Worklog Id: (was: 992902)
Time Spent: 1h 20m (was: 1h 10m)
> NullResponseMessage_V2 incorrect release from pool
> --------------------------------------------------
>
> Key: ARTEMIS-5775
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5775
> Project: Artemis
> Issue Type: Bug
> Reporter: Iliya Grushevskiy
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> NullResponseMessage_V2 might not be correctly released from the pool in
> ClientSessionFactoryImpl.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
