[
https://issues.apache.org/jira/browse/AMQ-9829?focusedWorklogId=1000951&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1000951
]
ASF GitHub Bot logged work on AMQ-9829:
---------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/26 10:32
Start Date: 20/Jan/26 10:32
Worklog Time Spent: 10m
Work Description: jeanouii commented on code in PR #1616:
URL: https://github.com/apache/activemq/pull/1616#discussion_r2707747606
##########
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageConsumer.java:
##########
@@ -933,6 +943,16 @@ private void beforeMessageIsConsumed(MessageDispatch md)
throws JMSException {
if (!isAutoAcknowledgeBatch()) {
synchronized(deliveredMessages) {
deliveredMessages.addFirst(md);
+ if (session.isTransacted()) {
Review Comment:
The bug (prefetched messages not redelivered after transaction failure) was
related to transactions only. So I did not wanted to impact other scenarios.
But there is outside of this a rational.
The previouslyDeliveredMessages map (and prefetchedOnly) is only used to
track rollback/redelivery behavior, which only exists for transacted sessions.
In a non‑transacted session there is no rollback; delivery state is driven by
the ack mode (AUTO/CLIENT/DUPS_OK).
Issue Time Tracking
-------------------
Worklog Id: (was: 1000951)
Time Spent: 1h 20m (was: 1h 10m)
> Track prefetched messages for duplicate suppression during failover
> -------------------------------------------------------------------
>
> Key: AMQ-9829
> URL: https://issues.apache.org/jira/browse/AMQ-9829
> Project: ActiveMQ
> Issue Type: Bug
> Reporter: Jean-Louis Monteiro
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Discovered with {{FailoverDurableSubTransactionTest}} flacky test
> During failover, messages were wrongly detected as being duplicated and sent
> to DLQ.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
