[
https://issues.apache.org/jira/browse/AMQ-9829?focusedWorklogId=1001046&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1001046
]
ASF GitHub Bot logged work on AMQ-9829:
---------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/26 17:49
Start Date: 20/Jan/26 17:49
Worklog Time Spent: 10m
Work Description: jbonofre commented on code in PR #1616:
URL: https://github.com/apache/activemq/pull/1616#discussion_r2709442512
##########
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageConsumer.java:
##########
@@ -771,6 +778,9 @@ void clearMessagesInProgress() {
// ensure unconsumed are rolledback up front as they may
get redelivered to another consumer
List<MessageDispatch> list =
unconsumedMessages.removeAll();
if (!this.info.isBrowser()) {
+ if (session.isTransacted()) {
+
capturePrefetchedMessagesForDuplicateSuppression(list);
Review Comment:
That's a good catch from @cshannon . I think we can avoid dual looping here.
Issue Time Tracking
-------------------
Worklog Id: (was: 1001046)
Time Spent: 1h 50m (was: 1h 40m)
> Track prefetched messages for duplicate suppression during failover
> -------------------------------------------------------------------
>
> Key: AMQ-9829
> URL: https://issues.apache.org/jira/browse/AMQ-9829
> Project: ActiveMQ
> Issue Type: Bug
> Reporter: Jean-Louis Monteiro
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Discovered with {{FailoverDurableSubTransactionTest}} flacky test
> During failover, messages were wrongly detected as being duplicated and sent
> to DLQ.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
