[
https://issues.apache.org/jira/browse/AIRAVATA-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411477#comment-16411477
]
ASF GitHub Bot commented on AIRAVATA-2657:
------------------------------------------
DImuthuUpe commented on a change in pull request #167: [AIRAVATA-2657]
Refactoring App Catalog Implementation - ApplicationDeployment and
ApplicationInterface Modules
URL: https://github.com/apache/airavata/pull/167#discussion_r176754498
##########
File path:
modules/registry-refactoring/src/main/java/org/apache/airavata/registry/core/repositories/appcatalog/ApplicationDeploymentRepository.java
##########
@@ -43,16 +44,24 @@ public ApplicationDeploymentRepository() {
}
protected String saveApplicationDeploymentDescriptorData(
- ApplicationDeploymentDescription applicationDeploymentDescription)
throws AppCatalogException {
- ApplicationDeploymentEntity applicationDeploymentEntity =
saveApplicationDeployment(applicationDeploymentDescription);
- return applicationDeploymentEntity.getDeploymentId();
+ ApplicationDeploymentDescription applicationDeploymentDescription,
String gatewayId) throws AppCatalogException {
+ ApplicationDeploymentEntity applicationDeploymentEntity =
saveApplicationDeployment(applicationDeploymentDescription, gatewayId);
+ return applicationDeploymentEntity.getAppDeploymentId();
}
protected ApplicationDeploymentEntity saveApplicationDeployment(
- ApplicationDeploymentDescription applicationDeploymentDescription)
throws AppCatalogException {
+ ApplicationDeploymentDescription applicationDeploymentDescription,
String gatewayId) throws AppCatalogException {
String applicationDeploymentId =
applicationDeploymentDescription.getAppDeploymentId();
Mapper mapper = ObjectMapperSingleton.getInstance();
ApplicationDeploymentEntity applicationDeploymentEntity =
mapper.map(applicationDeploymentDescription, ApplicationDeploymentEntity.class);
+ if (gatewayId != null)
Review comment:
This logic is bit complex. Better if you can add debug logs in each if
block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactoring App Catalog implementation - ApplicationDeployment and
> ApplicationInterface
> ---------------------------------------------------------------------------------------
>
> Key: AIRAVATA-2657
> URL: https://issues.apache.org/jira/browse/AIRAVATA-2657
> Project: Airavata
> Issue Type: Task
> Components: Application Catalog
> Reporter: Sneha Tilak
> Assignee: Sneha Tilak
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
