[
https://issues.apache.org/jira/browse/AIRAVATA-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411488#comment-16411488
]
ASF GitHub Bot commented on AIRAVATA-2657:
------------------------------------------
DImuthuUpe commented on a change in pull request #167: [AIRAVATA-2657]
Refactoring App Catalog Implementation - ApplicationDeployment and
ApplicationInterface Modules
URL: https://github.com/apache/airavata/pull/167#discussion_r176755873
##########
File path:
modules/registry-refactoring/src/main/java/org/apache/airavata/registry/core/repositories/appcatalog/ApplicationInterfaceRepository.java
##########
@@ -122,15 +130,15 @@ public ApplicationModule getApplicationModule(String
moduleId) throws AppCatalog
ApplicationModuleRepository applicationModuleRepository = new
ApplicationModuleRepository();
Map<String, Object> queryParameters = new HashMap<>();
queryParameters.put(DBConstants.ApplicationModule.APPLICATION_MODULE_ID,
moduleId);
- ApplicationModule applicationModule = (ApplicationModule)
applicationModuleRepository.select(QueryConstants.FIND_APPLICATION_MODULE, -1,
0, queryParameters);
+ ApplicationModule applicationModule =
applicationModuleRepository.select(QueryConstants.FIND_APPLICATION_MODULE, -1,
0, queryParameters).get(0);
Review comment:
Is it guaranteed this to return at least one value? Otherwise it is risky to
directly call get(0)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactoring App Catalog implementation - ApplicationDeployment and
> ApplicationInterface
> ---------------------------------------------------------------------------------------
>
> Key: AIRAVATA-2657
> URL: https://issues.apache.org/jira/browse/AIRAVATA-2657
> Project: Airavata
> Issue Type: Task
> Components: Application Catalog
> Reporter: Sneha Tilak
> Assignee: Sneha Tilak
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
