[
https://issues.apache.org/jira/browse/ARIA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036322#comment-16036322
]
ASF GitHub Bot commented on ARIA-262:
-------------------------------------
Github user mxmrlv commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/141#discussion_r120014181
--- Diff: aria/orchestrator/decorators.py ---
@@ -68,11 +68,13 @@ def operation(func=None, toolbelt=False,
suffix_template='', logging_handlers=No
@wraps(func)
def _wrapper(**func_kwargs):
+ ctx = func_kwargs.pop('ctx')
if toolbelt:
- operation_toolbelt = context.toolbelt(func_kwargs['ctx'])
+ operation_toolbelt = context.toolbelt(ctx)
func_kwargs.setdefault('toolbelt', operation_toolbelt)
- validate_function_arguments(func, func_kwargs)
- return func(**func_kwargs)
+ validate_function_arguments(func, ctx=ctx, **func_kwargs)
--- End diff --
instead of pop, use get, dont use **, later pop ctx.
> Inconsistent node attributes behavior
> -------------------------------------
>
> Key: ARIA-262
> URL: https://issues.apache.org/jira/browse/ARIA-262
> Project: AriaTosca
> Issue Type: Story
> Reporter: Maxim Orlov
> Assignee: Maxim Orlov
>
> ARIA provides sugaring for node attributes. However this sugaring is somewhat
> limited, as it sugars ctx accessed attributes. e.g. Under
> NodeOperationContext {{ctx.node.attributes}} has a dict-like behavior, where
> the value is another object with a dict-like behavior. This is provided by
> the sugaring.
> However {{ctx.node.relationships[0].target_node.attributes}} provides a dict
> where the value is of type Parameter, accessing the value of this Parameter
> requires {{param.value}} This creates inconsistency with regards to access to
> attributes.
> There are several possible solutions:
> 1. Enable sugaring on the model level. this will effectively make the
> creation of Parameter implicit, but this will be possible throughout the
> entire code (not only under context).
> 2. Enable sugaring by tapping to sqla events and altering the return values.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
