[ 
https://issues.apache.org/jira/browse/ARROW-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192983#comment-16192983
 ] 

ASF GitHub Bot commented on ARROW-1473:
---------------------------------------

Github user icexelloss commented on the issue:

    https://github.com/apache/arrow/pull/1164
  
    @siddharthteotia This looks good so far. What I am concerned with are code 
duplication and maintainability if we hand write all the vector class. Can you 
maybe show (or describe) how `NullableLongVector` and `IntVector` would work? 
Specially for those setter/getter method.
    
    I think @wesm suggested not having non-nullable/nullable vectors be two 
separate class to reduce the number of classes. We should discussion more on 
this.
    



> [JAVA] Create Prototype Code Hierarchy (alt A)
> ----------------------------------------------
>
>                 Key: ARROW-1473
>                 URL: https://issues.apache.org/jira/browse/ARROW-1473
>             Project: Apache Arrow
>          Issue Type: Sub-task
>            Reporter: Jacques Nadeau
>            Assignee: Siddharth Teotia
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to