[ 
https://issues.apache.org/jira/browse/ARROW-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197492#comment-16197492
 ] 

ASF GitHub Bot commented on ARROW-1473:
---------------------------------------

Github user siddharthteotia commented on the issue:

    https://github.com/apache/arrow/pull/1164
  
    
    Notes on recent changes:
    
    Addressed some comments. Some in progress.
    
    - The current patch has the basic implementation of interfaces for Nullable 
Fixed and Variable Width vectors with corresponding concrete implementation of 
respective subclasses - NullableIntVector, NullableVarCharVector.
    
    - Question: do we need allocationMonitor in our vector code? It complicates 
the logic of allocateNewSafe() and realloc().
    
    - Question: do we need setting reader and writer index on arrow bufs inside 
vectors? I think it doesn't really matter and vector get/set methods should 
still work fine.



> [JAVA] Create Prototype Code Hierarchy (alt A)
> ----------------------------------------------
>
>                 Key: ARROW-1473
>                 URL: https://issues.apache.org/jira/browse/ARROW-1473
>             Project: Apache Arrow
>          Issue Type: Sub-task
>            Reporter: Jacques Nadeau
>            Assignee: Siddharth Teotia
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to