[
https://issues.apache.org/jira/browse/ARROW-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226573#comment-16226573
]
ASF GitHub Bot commented on ARROW-1753:
---------------------------------------
dhirschfeld commented on a change in pull request #1272: ARROW-1753 [Python]
Provide for matching subclasses with register_type in serialization context
URL: https://github.com/apache/arrow/pull/1272#discussion_r147948595
##########
File path: python/pyarrow/serialization.pxi
##########
@@ -88,17 +88,26 @@ cdef class SerializationContext:
self.custom_deserializers[type_id] = custom_deserializer
def _serialize_callback(self, obj):
- if type(obj) not in self.type_to_type_id:
+ FOUND = False
Review comment:
Fixed and force-pushed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] Provide for matching subclasses with register_type in serialization
> context
> ------------------------------------------------------------------------------------
>
> Key: ARROW-1753
> URL: https://issues.apache.org/jira/browse/ARROW-1753
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
> Reporter: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> Copied from https://github.com/apache/arrow/issues/1269
> To allow factoring out serialization code to a common base class it would be
> useful if register_type matches all subclasses rather than simply an exact
> match on the specific type.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
