[
https://issues.apache.org/jira/browse/ARROW-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226688#comment-16226688
]
ASF GitHub Bot commented on ARROW-1753:
---------------------------------------
dhirschfeld commented on issue #1272: ARROW-1753 [Python] Provide for matching
subclasses with register_type in serialization context
URL: https://github.com/apache/arrow/pull/1272#issuecomment-340745184
I might try to get it building first (Win64/py36) as it's pretty hard to do
any real development if you can't test it. In case it rings any bells the
errors I'm seeing are:
```
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\x86_amd64\CL.exe
/c
/I"C:\Miniconda3\conda-bld\pyarrow_1509440425653\_h_env\lib\site-packages\numpy\core\include"
/I"C:\Miniconda3\conda-bld\pyarrow_1509440425653\_h_env\include"
/I"C:\Miniconda3\conda-bld\pyarrow_1509440425653\work\python\src"
/I"C:\Miniconda3\conda-bld\pyarrow_1509440425653\_h_env\Library\include"
/nologo /W3 /WX- /O2 /Ob2 /D WIN32 /D _WINDOWS /D NDEBUG /D
_CRT_SECURE_NO_WARNINGS /D ARROW_EXPORTING
/D "CMAKE_INTDIR=\"Release\"" /D lib_EXPORTS /D _WINDLL /D _MBCS /Gm-
/EHsc /MD /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR
/Fo"lib.dir\Release\\" /Fd"lib.dir\Release\vc140.pdb" /Gd /TP /wd4190
/wd4293 /wd4800
/errorReport:queue
"C:\Miniconda3\conda-bld\pyarrow_1509440425653\work\python\build\temp.win-amd64-3.6\Release\lib.cxx"
lib.cxx
C:\Miniconda3\conda-bld\pyarrow_1509440425653\work\python\build\temp.win-amd64-3.6\Release\lib.cxx(30527):
error C2039: 'NdarrayToArrow': is not a member of 'arrow::py'
[C:\Miniconda3\conda-bld\pyarrow_1509440425653\work\python\build\temp.win-amd64-3.6\Release\lib.vcxproj]
C:\Miniconda3\conda-bld\pyarrow_1509440425653\_h_env\Library\include\arrow/python/pandas_to_arrow.h(37):
note: see declaration of 'arrow::py'
C:\Miniconda3\conda-bld\pyarrow_1509440425653\work\python\build\temp.win-amd64-3.6\Release\lib.cxx(32515):
error C2039: 'allow_time_truncate': is not a member of
'arrow::compute::CastOptions'
[C:\Miniconda3\conda-bld\pyarrow_1509440425653\work\python\build\temp.win-amd64-3.6\Release\lib.vcxproj]
C:\Miniconda3\conda-bld\pyarrow_1509440425653\_h_env\Library\include\arrow/compute/cast.h(36):
note: see declaration of 'arrow::compute::CastOptions'
C:\Miniconda3\conda-bld\pyarrow_1509440425653\work\python\build\temp.win-amd64-3.6\Release\lib.cxx(33975):
error C2039: 'zero_copy_only': is not a member of 'arrow::py::PandasOptions'
[C:\Miniconda3\conda-bld\pyarrow_1509440425653\work\python\build\temp.win-amd64-3.6\Release\lib.vcxproj]
C:\Miniconda3\conda-bld\pyarrow_1509440425653\_h_env\Library\include\arrow/python/arrow_to_pandas.h(42):
note: see declaration of 'arrow::py::PandasOptions'
```
It's bedtime in this neck of the woods however so that'll be a problem for
tomorrow...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] Provide for matching subclasses with register_type in serialization
> context
> ------------------------------------------------------------------------------------
>
> Key: ARROW-1753
> URL: https://issues.apache.org/jira/browse/ARROW-1753
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
> Reporter: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> Copied from https://github.com/apache/arrow/issues/1269
> To allow factoring out serialization code to a common base class it would be
> useful if register_type matches all subclasses rather than simply an exact
> match on the specific type.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
