[
https://issues.apache.org/jira/browse/ARROW-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226658#comment-16226658
]
ASF GitHub Bot commented on ARROW-1753:
---------------------------------------
dhirschfeld commented on issue #1272: ARROW-1753 [Python] Provide for matching
subclasses with register_type in serialization context
URL: https://github.com/apache/arrow/pull/1272#issuecomment-340738439
*Aside:* It seems to me there's no real need to special-case pickle:
```python
def register_type(self, type_, type_id, pickle=False,
custom_serializer=None, custom_deserializer=None):
```
...as it could easily be supported by simply passing:
```python
custom_serializer = lambda obj: {"data": pickle.dumps(obj)}
custom_deserializer = lambda obj: pickle.loads(obj["data"])
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] Provide for matching subclasses with register_type in serialization
> context
> ------------------------------------------------------------------------------------
>
> Key: ARROW-1753
> URL: https://issues.apache.org/jira/browse/ARROW-1753
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
> Reporter: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> Copied from https://github.com/apache/arrow/issues/1269
> To allow factoring out serialization code to a common base class it would be
> useful if register_type matches all subclasses rather than simply an exact
> match on the specific type.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
