[
https://issues.apache.org/jira/browse/ARROW-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261692#comment-16261692
]
ASF GitHub Bot commented on ARROW-1816:
---------------------------------------
icexelloss commented on issue #1330: wip: ARROW-1816: [Java] Resolve new vector
classes structure for timestamp, date and maybe interval
URL: https://github.com/apache/arrow/pull/1330#issuecomment-346198938
@jacques-n During the refactoring, I discovered that union vector doesn't
support types with type params (i.e. Decimal and Timestamp), so I fixed that as
well. Now union vectors support decimal as well.
The PR now includes two major changes:
* Consolidate all timestamp vectors into a single vector class
* Add support for non-simple minor type (i.e., decimal, timestamp) in Union
Most of the template change is to support types with type params, most of
them replaces:
```
<#if !minor.typeParams?? >
// handle types with no type params
</#if>
```
to
```
<#if !minor.typeParams?? >
// handle types with no type params
<#else>
// handle types with type params
</#if>
```
Please take a look when you have chance. Thanks! Hopefully we can clean this
up and merge the week after Thanksgiving.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Resolve new vector classes structure for timestamp, date and maybe
> interval
> ----------------------------------------------------------------------------------
>
> Key: ARROW-1816
> URL: https://issues.apache.org/jira/browse/ARROW-1816
> Project: Apache Arrow
> Issue Type: Sub-task
> Reporter: Li Jin
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> Personally I think having 8 vector classes for timestamps is not great. This
> is discussed at some point during the PR:
> https://github.com/apache/arrow/pull/1203#discussion_r145241388
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
