[
https://issues.apache.org/jira/browse/ARROW-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261714#comment-16261714
]
ASF GitHub Bot commented on ARROW-1816:
---------------------------------------
icexelloss commented on a change in pull request #1330: wip: ARROW-1816: [Java]
Resolve new vector classes structure for timestamp, date and maybe interval
URL: https://github.com/apache/arrow/pull/1330#discussion_r152436633
##########
File path: java/vector/src/main/codegen/data/ValueVectorTypes.tdd
##########
@@ -116,7 +100,7 @@
{
class: "Decimal",
maxPrecisionDigits: 38, nDecimalDigits: 4, friendlyType:
"BigDecimal",
- typeParams: [ {name: "scale", type: "int"}, { name: "precision",
type: "int"}],
+ typeParams: [ { name: "precision", type: "int"}, {name: "scale",
type: "int"} ],
Review comment:
The reverse ordering the these typeParams are driving me nuts... I changed
it such that they follow the same order everywhere. Also see:
https://github.com/apache/arrow/pull/1330/files#r152436539
The end results are the same because flipped twice..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Resolve new vector classes structure for timestamp, date and maybe
> interval
> ----------------------------------------------------------------------------------
>
> Key: ARROW-1816
> URL: https://issues.apache.org/jira/browse/ARROW-1816
> Project: Apache Arrow
> Issue Type: Sub-task
> Reporter: Li Jin
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> Personally I think having 8 vector classes for timestamps is not great. This
> is discussed at some point during the PR:
> https://github.com/apache/arrow/pull/1203#discussion_r145241388
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
