[
https://issues.apache.org/jira/browse/ARROW-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261300#comment-16261300
]
ASF GitHub Bot commented on ARROW-1816:
---------------------------------------
BryanCutler commented on a change in pull request #1330: wip: ARROW-1816:
[Java] Resolve new vector classes structure for timestamp, date and maybe
interval
URL: https://github.com/apache/arrow/pull/1330#discussion_r152365593
##########
File path: java/vector/src/main/codegen/templates/UnionVector.java
##########
@@ -138,16 +138,20 @@ private void setReaderAndWriterIndex() {
throw new UnsupportedOperationException("There are no inner vectors. Use
geFieldBuffers");
}
- private String fieldName(MinorType type) {
- return type.name().toLowerCase();
+ private String fieldName(ArrowType type) {
+ return Types.getMinorTypeForArrowType(type).name().toLowerCase();
}
- private FieldType fieldType(MinorType type) {
- return FieldType.nullable(type.getType());
- }
+ // private FieldType fieldType(MinorType type) {
+ // return FieldType.nullable(type.getType());
+ // }
+
+ // private <T extends FieldVector> T addOrGet(MinorType minorType, Class<T>
c) {
+ // return internalMap.addOrGet(fieldName(minorType), fieldType(minorType),
c);
+ // }
Review comment:
forgot to remove?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Resolve new vector classes structure for timestamp, date and maybe
> interval
> ----------------------------------------------------------------------------------
>
> Key: ARROW-1816
> URL: https://issues.apache.org/jira/browse/ARROW-1816
> Project: Apache Arrow
> Issue Type: Sub-task
> Reporter: Li Jin
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> Personally I think having 8 vector classes for timestamps is not great. This
> is discussed at some point during the PR:
> https://github.com/apache/arrow/pull/1203#discussion_r145241388
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
