[
https://issues.apache.org/jira/browse/ARROW-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271833#comment-16271833
]
ASF GitHub Bot commented on ARROW-1864:
---------------------------------------
johnou commented on a change in pull request #1376: ARROW-1864: [Java] Upgrade
Netty to 4.1.17
URL: https://github.com/apache/arrow/pull/1376#discussion_r153951640
##########
File path: java/memory/src/main/java/io/netty/buffer/ArrowBuf.java
##########
@@ -494,30 +495,27 @@ public ArrowBuf retain() {
}
@Override
- public long getLong(int index) {
- chk(index, 8);
- final long v = PlatformDependent.getLong(addr(index));
- return v;
- }
-
- @Override
- public float getFloat(int index) {
- return Float.intBitsToFloat(getInt(index));
+ public ByteBuf touch() {
+ return this;
}
@Override
- public double getDouble(int index) {
- return Double.longBitsToDouble(getLong(index));
+ public ByteBuf touch(Object hint) {
+ return this;
}
@Override
- public char getChar(int index) {
- return (char) getShort(index);
+ public long getLong(int index) {
+ chk(index, 8);
+ final long v = PlatformDependent.getLong(addr(index));
Review comment:
@zsxwing you might want to refrain from using PlatformDependent as it is in
an internal package..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Upgrade Netty to 4.1.x
> -----------------------------
>
> Key: ARROW-1864
> URL: https://issues.apache.org/jira/browse/ARROW-1864
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Java - Memory
> Reporter: Shixiong Zhu
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> The Netty community will declare Netty 4.0.x as EOL at the beginning of the
> second quarter of 2018: https://github.com/netty/netty/issues/7439
> It would be great that Arrow can migrate to Netty 4.1.x soon. This is the
> only blocker for Spark to migrate to Netty 4.1.x.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
