[
https://issues.apache.org/jira/browse/ARROW-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271836#comment-16271836
]
ASF GitHub Bot commented on ARROW-1864:
---------------------------------------
siddharthteotia commented on issue #1376: ARROW-1864: [Java] Upgrade Netty to
4.1.17
URL: https://github.com/apache/arrow/pull/1376#issuecomment-348036717
Is netty upgrade requiring some changes? Why are we removing methods from
ArrowBuf?
ArrowBuf and related memory classes bypass the class hierarchy structure in
some places and that is by design for performance reasons -- instead of
delegating, we directly interact with memory. If I am understanding the code
changes correctly, seems like removal of certain functions will change this.
I don't think so we should be doing that unless there is a strong reason or
netty upgrade is forcing this change.
For example, when a BigIntVector does a getLong(index), the function in
ArrowBuf grabs the memory address, computes the target virtual address and
fetches the value. Removal of getLong() will now require us to go down the
hierarchy of other netty classes -- AbstractByteBuf, MutableByteBuf etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Upgrade Netty to 4.1.x
> -----------------------------
>
> Key: ARROW-1864
> URL: https://issues.apache.org/jira/browse/ARROW-1864
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Java - Memory
> Reporter: Shixiong Zhu
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> The Netty community will declare Netty 4.0.x as EOL at the beginning of the
> second quarter of 2018: https://github.com/netty/netty/issues/7439
> It would be great that Arrow can migrate to Netty 4.1.x soon. This is the
> only blocker for Spark to migrate to Netty 4.1.x.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
