[ 
https://issues.apache.org/jira/browse/ARROW-1832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278610#comment-16278610
 ] 

ASF GitHub Bot commented on ARROW-1832:
---------------------------------------

TheNeuralBit commented on issue #1343: [WIP] ARROW-1832: [JS] Implement JSON 
reader for integration tests
URL: https://github.com/apache/arrow/pull/1343#issuecomment-349317350
 
 
   @trxcllnt here's a summary of the major remaining tasks on this item as I 
see it:
   
   1. Use strings for 64-bit ints everywhere, get rid of json-bignum dependency 
([ARROW-1875](https://issues.apache.org/jira/browse/ARROW-1875)).
   1. Use an actual equality check in `bin/integration.js` rather than 
comparing `Table.toString()`. Ideally, include diffs in output.
   1. Create a `JSONReaderContext` implementation of `VectorReaderContext` and 
re-use the vector readers.
   
   I think the first two can wait until future PRs, but I'd like to get the 
last one done - what do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> [JS] Implement JSON reader for integration tests
> ------------------------------------------------
>
>                 Key: ARROW-1832
>                 URL: https://issues.apache.org/jira/browse/ARROW-1832
>             Project: Apache Arrow
>          Issue Type: New Feature
>          Components: JavaScript
>            Reporter: Brian Hulette
>            Assignee: Brian Hulette
>              Labels: pull-request-available
>
> Implementing a JSON reader will allow us to write a "validate" script for the 
> consumer half of the integration tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to