[
https://issues.apache.org/jira/browse/ARROW-1832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262414#comment-16262414
]
ASF GitHub Bot commented on ARROW-1832:
---------------------------------------
trxcllnt commented on a change in pull request #1343: [WIP] ARROW-1832: [JS]
Implement JSON reader for integration tests
URL: https://github.com/apache/arrow/pull/1343#discussion_r152544796
##########
File path: js/src/format/arrow.ts
##########
@@ -0,0 +1,61 @@
+import { flatbuffers } from 'flatbuffers';
+
+import * as Schema_ from './Schema';
+import * as Message_ from './Message';
+import * as File_ from './Message';
+
+export namespace fb {
+ export import Schema = Schema_.org.apache.arrow.flatbuf;
+ export import Message = Message_.org.apache.arrow.flatbuf;
+ export import File = File_.org.apache.arrow.flatbuf;
+}
Review comment:
Ah, actually I spoke too soon. The way TS compiles namespaces to nested
IEFEs in JS confuses Closure Compiler's mangler, so all the `fb.Schema.Foo`
references get mangled to different names. I remember figuring this out when I
first turned on CC, and that's why we do the ugly `import * as Schema_` and
`import Type = Schema_.org.apache.arrow.flatbuf.Type` nonsense everywhere. Ugh.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JS] Implement JSON reader for integration tests
> ------------------------------------------------
>
> Key: ARROW-1832
> URL: https://issues.apache.org/jira/browse/ARROW-1832
> Project: Apache Arrow
> Issue Type: New Feature
> Components: JavaScript
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Labels: pull-request-available
>
> Implementing a JSON reader will allow us to write a "validate" script for the
> consumer half of the integration tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
