[
https://issues.apache.org/jira/browse/ARROW-1832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263726#comment-16263726
]
ASF GitHub Bot commented on ARROW-1832:
---------------------------------------
trxcllnt commented on issue #1343: [WIP] ARROW-1832: [JS] Implement JSON reader
for integration tests
URL: https://github.com/apache/arrow/pull/1343#issuecomment-346523014
@TheNeuralBit thinking about this more, I think with a few modifications we
could reuse all the [vector
reader](https://github.com/apache/arrow/blob/9b2dc77a4d95c7415edd5be087a5abafc5a7f64c/js/src/reader/vector.ts#L49)
functions for the JSON reader.
If we move [`createTypedArray` and
`createValidityArray`](https://github.com/apache/arrow/blob/9b2dc77a4d95c7415edd5be087a5abafc5a7f64c/js/src/reader/vector.ts#L261)
into the `VectorReaderContext` interface, the `offset` field can become a
private impl detail of how the
[`BufferReaderContext`](https://github.com/apache/arrow/blob/9b2dc77a4d95c7415edd5be087a5abafc5a7f64c/js/src/reader/arrow.ts#L167)
creates TypedArrays. Then we can implement a `JSONReaderContext` that creates
its TypedArrays from the json. Lastly, we can keep going with your idea for
shimming the flatbuffers interfaces. With a bit of reflection I think we can
make this pretty slim.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JS] Implement JSON reader for integration tests
> ------------------------------------------------
>
> Key: ARROW-1832
> URL: https://issues.apache.org/jira/browse/ARROW-1832
> Project: Apache Arrow
> Issue Type: New Feature
> Components: JavaScript
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Labels: pull-request-available
>
> Implementing a JSON reader will allow us to write a "validate" script for the
> consumer half of the integration tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
