[
https://issues.apache.org/jira/browse/ARROW-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292549#comment-16292549
]
ASF GitHub Bot commented on ARROW-764:
--------------------------------------
xhochy commented on a change in pull request #1422: WIP ARROW-764: [C++]
Improves performance of CopyBitmap and adds benchmarks
URL: https://github.com/apache/arrow/pull/1422#discussion_r157203899
##########
File path: cpp/src/arrow/util/CMakeLists.txt
##########
@@ -57,11 +57,16 @@ if (ARROW_BUILD_BENCHMARKS)
target_link_libraries(arrow_benchmark_main
benchmark
)
+ elseif(MSVC)
+ target_link_libraries(arrow_benchmark_main
+ benchmark
+ Shlwapi.lib
+ )
else()
- target_link_libraries(arrow_benchmark_main
+ target_link_libraries(arrow_benchmark_main
Review comment:
Can you remove these reindentations?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Improve performance of CopyBitmap, add benchmarks
> -------------------------------------------------------
>
> Key: ARROW-764
> URL: https://issues.apache.org/jira/browse/ARROW-764
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> This is follow up work after a discussion in the patch for ARROW-657
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
