[
https://issues.apache.org/jira/browse/ARROW-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301930#comment-16301930
]
ASF GitHub Bot commented on ARROW-764:
--------------------------------------
seibs commented on issue #1422: WIP ARROW-764: [C++] Improves performance of
CopyBitmap and adds benchmarks
URL: https://github.com/apache/arrow/pull/1422#issuecomment-353670256
Thanks for taking a look @xhochy.
My latest push fixes the formatting issues and also adds a test+fix for a
few corner cases my first upload didn't handle correctly.
**Benchmark with recent changes**
```
Run on (4 X 2208 MHz CPU s)
12/22/17 15:14:31
Benchmark Time CPU
Iterations
------------------------------------------------------------------------------
BM_CopyBitmap/97.6563k/0/min_time:1.000 5 us 5 us
270310 17.9019GB/s
BM_CopyBitmap/976.563k/0/min_time:1.000 65 us 65 us
21854 14.3143GB/s
BM_CopyBitmap/97.6563k/4/min_time:1.000 153 us 152 us
8960 628.592MB/s
BM_CopyBitmap/976.563k/4/min_time:1.000 1534 us 1535 us
896 621.449MB/s
```
w.r.t. the comments above in `CMakeLists.txt`, I actually have a separate
pull request open for them at #1406.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Improve performance of CopyBitmap, add benchmarks
> -------------------------------------------------------
>
> Key: ARROW-764
> URL: https://issues.apache.org/jira/browse/ARROW-764
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> This is follow up work after a discussion in the patch for ARROW-657
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
