[
https://issues.apache.org/jira/browse/ARROW-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315440#comment-16315440
]
ASF GitHub Bot commented on ARROW-764:
--------------------------------------
wesm commented on issue #1422: ARROW-764: [C++] Improves performance of
CopyBitmap and adds benchmarks
URL: https://github.com/apache/arrow/pull/1422#issuecomment-355845940
@siddharthteotia there's a couple places in the codebase where we copy bits
out of a bitmap, e.g. after slicing vectors
https://github.com/apache/arrow/blob/2e3832f34a8933c1ef81331e6d1dde5190366852/cpp/src/arrow/ipc/writer.cc#L63.
Depending on the slice offset (whether it's a multiple of 8) we have to either
copy 1 bit at a time or do a memcpy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Improve performance of CopyBitmap, add benchmarks
> -------------------------------------------------------
>
> Key: ARROW-764
> URL: https://issues.apache.org/jira/browse/ARROW-764
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Assignee: Adam Seibert
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> This is follow up work after a discussion in the patch for ARROW-657
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
