[ 
https://issues.apache.org/jira/browse/ARROW-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369661#comment-16369661
 ] 

ASF GitHub Bot commented on ARROW-1632:
---------------------------------------

cpcloud commented on a change in pull request #1620: ARROW-1632: [Python] 
Permit categorical conversions in Table.to_pandas on a per-column basis
URL: https://github.com/apache/arrow/pull/1620#discussion_r169206390
 
 

 ##########
 File path: cpp/src/arrow/python/arrow_to_pandas.cc
 ##########
 @@ -986,7 +987,8 @@ class CategoricalBlock : public PandasBlock {
     // Sniff the first chunk
     const std::shared_ptr<Array> arr_first = data.chunk(0);
     const auto& dict_arr_first = static_cast<const 
DictionaryArray&>(*arr_first);
-    const auto& indices_first = static_cast<const 
ArrayType&>(*dict_arr_first.indices());
+    const std::shared_ptr<ArrayType> indices_first =
 
 Review comment:
   This can use `auto`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Python] Permit categorical conversions in Table.to_pandas on a per-column 
> basis
> --------------------------------------------------------------------------------
>
>                 Key: ARROW-1632
>                 URL: https://issues.apache.org/jira/browse/ARROW-1632
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Python
>            Reporter: Wes McKinney
>            Assignee: Uwe L. Korn
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.9.0
>
>
> Currently this is all or nothing



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to