[
https://issues.apache.org/jira/browse/ARROW-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369663#comment-16369663
]
ASF GitHub Bot commented on ARROW-1632:
---------------------------------------
cpcloud commented on a change in pull request #1620: ARROW-1632: [Python]
Permit categorical conversions in Table.to_pandas on a per-column basis
URL: https://github.com/apache/arrow/pull/1620#discussion_r169206499
##########
File path: python/pyarrow/includes/libarrow.pxd
##########
@@ -883,6 +883,7 @@ cdef extern from "arrow/python/api.h" namespace
"arrow::py" nogil:
object py_ref, PyObject** out)
CStatus ConvertTableToPandas(PandasOptions options,
+ unordered_set[c_string] categorical_columns,
Review comment:
Should this be `const unordered_set[c_string]&`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Python] Permit categorical conversions in Table.to_pandas on a per-column
> basis
> --------------------------------------------------------------------------------
>
> Key: ARROW-1632
> URL: https://issues.apache.org/jira/browse/ARROW-1632
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
> Reporter: Wes McKinney
> Assignee: Uwe L. Korn
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> Currently this is all or nothing
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
