[ 
https://issues.apache.org/jira/browse/ARROW-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378895#comment-16378895
 ] 

ASF GitHub Bot commented on ARROW-1632:
---------------------------------------

xhochy commented on a change in pull request #1620: ARROW-1632: [Python] Permit 
categorical conversions in Table.to_pandas on a per-column basis
URL: https://github.com/apache/arrow/pull/1620#discussion_r170985309
 
 

 ##########
 File path: cpp/src/arrow/python/arrow_to_pandas.h
 ##########
 @@ -64,6 +66,16 @@ ARROW_EXPORT
 Status ConvertTableToPandas(PandasOptions options, const 
std::shared_ptr<Table>& table,
                             int nthreads, MemoryPool* pool, PyObject** out);
 
+/// Convert a whole table as efficiently as possible to a pandas.DataFrame.
+///
+/// Explicitly name columns that should be a categorical
+/// This option is only used on conversions that are applied to a table.
+ARROW_EXPORT
+Status ConvertTableToPandas(PandasOptions options,
+                            const std::unordered_set<std::string>& 
categorical_columns,
 
 Review comment:
   I was looking at doing that but the options structure also makes sense on a 
per-column basis (and we use it for that) bur the column list is only useful in 
the Table case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> [Python] Permit categorical conversions in Table.to_pandas on a per-column 
> basis
> --------------------------------------------------------------------------------
>
>                 Key: ARROW-1632
>                 URL: https://issues.apache.org/jira/browse/ARROW-1632
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Python
>            Reporter: Wes McKinney
>            Assignee: Uwe L. Korn
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.9.0
>
>
> Currently this is all or nothing



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to