[
https://issues.apache.org/jira/browse/ARROW-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407192#comment-16407192
]
ASF GitHub Bot commented on ARROW-2328:
---------------------------------------
Adriandorr commented on a change in pull request #1766: ARROW-2328: [C++]
Writing a slice with feather ignores the offset.
URL: https://github.com/apache/arrow/pull/1766#discussion_r175948619
##########
File path: cpp/src/arrow/ipc/feather.cc
##########
@@ -603,7 +602,12 @@ class TableWriter::TableWriterImpl : public ArrayVisitor {
}
if (prim_values.values()) {
- values_buffer = prim_values.values()->data();
+ if (prim_values.offset() != 0 && (fw_type.bit_width() % 8 != 0)) {
+ return arrow::Status::Invalid(
Review comment:
Thanks for your comments. I've changed the status return code. But I'm
having two problems:
* when I run 'make format' it only changes a whole bunch of files I didn't
change. Was master broken when I forked?
* SliceStringsRoundTrip fails and I'm struggling to understand which of the
various offsets needs to be adjusted. I can probably figure that out tomorrow.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Writing a slice with feather ignores the offset
> -----------------------------------------------
>
> Key: ARROW-2328
> URL: https://issues.apache.org/jira/browse/ARROW-2328
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Affects Versions: 0.8.0
> Reporter: Adrian
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> Writing a slice from row n of length m of an array to feather would write the
> first m rows, instead of the rows starting at n.
> I've created a pull request with tests and fix here:
> [Pullrequest#1766|https://github.com/apache/arrow/pull/1766]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
