[
https://issues.apache.org/jira/browse/ARROW-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407661#comment-16407661
]
ASF GitHub Bot commented on ARROW-2328:
---------------------------------------
Adriandorr commented on issue #1766: ARROW-2328: [C++] Writing a slice with
feather ignores the offset.
URL: https://github.com/apache/arrow/pull/1766#issuecomment-374875952
In the latest commit I have unit tested and fixed the null bitmap bug. I
ended up adding the memory pool argument with a nullptr default and fail if an
array is sliced and no pool was passed in.
I also copy and pasted GetTruncatedBitmap from writer.cpp, I wasn't sure how
to share it without it leaking into the public api.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Writing a slice with feather ignores the offset
> -----------------------------------------------
>
> Key: ARROW-2328
> URL: https://issues.apache.org/jira/browse/ARROW-2328
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Affects Versions: 0.8.0
> Reporter: Adrian
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> Writing a slice from row n of length m of an array to feather would write the
> first m rows, instead of the rows starting at n.
> The null bitmap also ends up misaligned. Also tested and fixed in the pull
> request below.
> I've created a pull request with tests and fix here:
> [Pullrequest#1766|https://github.com/apache/arrow/pull/1766]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
