[
https://issues.apache.org/jira/browse/ARROW-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411292#comment-16411292
]
ASF GitHub Bot commented on ARROW-2328:
---------------------------------------
Adriandorr opened a new pull request #1784: (ARROW-2328: [C++] Fixed and unit
tested feather writing with slice
URL: https://github.com/apache/arrow/pull/1784
When writing a slice of a table to feather, both the scalar data and the
null bitmap were written out wrongly, i.e. from the beginning of the original
table instead of from the offset.
- scalar data is written from the offset
- null bitmap is written from the offset.
I messed up my original pull request
https://github.com/apache/arrow/pull/1766, hence this replaces it. Hope that
helps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Writing a slice with feather ignores the offset
> -----------------------------------------------
>
> Key: ARROW-2328
> URL: https://issues.apache.org/jira/browse/ARROW-2328
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Affects Versions: 0.8.0
> Reporter: Adrian
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.10.0
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> Writing a slice from row n of length m of an array to feather would write the
> first m rows, instead of the rows starting at n.
> The null bitmap also ends up misaligned. Also tested and fixed in the pull
> request below.
> I've created a pull request with tests and fix here:
> [Pullrequest#1766|https://github.com/apache/arrow/pull/1766]
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
