[
https://issues.apache.org/jira/browse/ARROW-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426975#comment-16426975
]
ASF GitHub Bot commented on ARROW-2402:
---------------------------------------
pitrou commented on issue #1841: ARROW-2402: [C++] Avoid spurious copies with
FixedSizeBinaryBuilder
URL: https://github.com/apache/arrow/pull/1841#issuecomment-378948242
Before:
```
Benchmark Time CPU
Iterations
------------------------------------------------------------------------------------
BM_BuildFixedSizeBinaryArray/repeats:3 88124 us 88090 us
8 113.52MB/s
BM_BuildFixedSizeBinaryArray/repeats:3 87680 us 87644 us
8 114.098MB/s
BM_BuildFixedSizeBinaryArray/repeats:3 88302 us 88262 us
8 113.299MB/s
BM_BuildFixedSizeBinaryArray/repeats:3_mean 88036 us 87999 us
8 113.639MB/s
BM_BuildFixedSizeBinaryArray/repeats:3_stddev 262 us 261 us
0 345.013kB/s
```
After:
```
Benchmark Time CPU
Iterations
------------------------------------------------------------------------------------
BM_BuildFixedSizeBinaryArray/repeats:3 12534 us 12506 us
56 799.587MB/s
BM_BuildFixedSizeBinaryArray/repeats:3 12553 us 12524 us
56 798.455MB/s
BM_BuildFixedSizeBinaryArray/repeats:3 12537 us 12518 us
56 798.85MB/s
BM_BuildFixedSizeBinaryArray/repeats:3_mean 12541 us 12516 us
56 798.964MB/s
BM_BuildFixedSizeBinaryArray/repeats:3_stddev 8 us 7 us
0 480.683kB/s
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] FixedSizeBinaryBuilder::Append lacks "const char*" overload
> -----------------------------------------------------------------
>
> Key: ARROW-2402
> URL: https://issues.apache.org/jira/browse/ARROW-2402
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Affects Versions: 0.9.0
> Reporter: Antoine Pitrou
> Priority: Major
> Labels: pull-request-available
>
> This implies that calling {{FixedSizeBinaryBuilder::Append}} with a "const
> char*" argument currently instantiates a temporary {{std::string}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)