ASF GitHub Bot commented on ARROW-2402:

xhochy commented on a change in pull request #1841: ARROW-2402: [C++] Avoid 
spurious copies with FixedSizeBinaryBuilder
URL: https://github.com/apache/arrow/pull/1841#discussion_r179759229

 File path: cpp/src/arrow/builder.h
 @@ -730,7 +730,14 @@ class ARROW_EXPORT FixedSizeBinaryBuilder : public 
ArrayBuilder {
   FixedSizeBinaryBuilder(const std::shared_ptr<DataType>& type,
                          MemoryPool* pool ARROW_MEMORY_POOL_DEFAULT);
-  Status Append(const uint8_t* value);
+  Status Append(const uint8_t* value) {
 Review comment:
   I understand the performance benefits of moving this to the header but this 
also reminds me that we should have a look at our build process. This will 
inline the code in more places but also makes binaries a bit larger, if we 
would build using `-fLTO` we should be able to get rid of those duplications 
while having even a bit better performance at the same time. 
   The change here is probably not significant at all but all the small ones 
add up over time.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> [C++] FixedSizeBinaryBuilder::Append lacks "const char*" overload
> -----------------------------------------------------------------
>                 Key: ARROW-2402
>                 URL: https://issues.apache.org/jira/browse/ARROW-2402
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: 0.9.0
>            Reporter: Antoine Pitrou
>            Priority: Major
>              Labels: pull-request-available
> This implies that calling {{FixedSizeBinaryBuilder::Append}} with a "const 
> char*" argument currently instantiates a temporary {{std::string}}.

This message was sent by Atlassian JIRA

Reply via email to