[
https://issues.apache.org/jira/browse/ARROW-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428363#comment-16428363
]
ASF GitHub Bot commented on ARROW-2402:
---------------------------------------
pitrou commented on a change in pull request #1841: ARROW-2402: [C++] Avoid
spurious copies with FixedSizeBinaryBuilder
URL: https://github.com/apache/arrow/pull/1841#discussion_r179767477
##########
File path: cpp/src/arrow/builder.h
##########
@@ -730,7 +730,14 @@ class ARROW_EXPORT FixedSizeBinaryBuilder : public
ArrayBuilder {
FixedSizeBinaryBuilder(const std::shared_ptr<DataType>& type,
MemoryPool* pool ARROW_MEMORY_POOL_DEFAULT);
- Status Append(const uint8_t* value);
+ Status Append(const uint8_t* value) {
Review comment:
The downside with LTO is inflated build times (the linking step becomes much
longer, and it isn't parallelized). Also IIRC some compilers have various bugs
or limitations with LTO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] FixedSizeBinaryBuilder::Append lacks "const char*" overload
> -----------------------------------------------------------------
>
> Key: ARROW-2402
> URL: https://issues.apache.org/jira/browse/ARROW-2402
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Affects Versions: 0.9.0
> Reporter: Antoine Pitrou
> Assignee: Antoine Pitrou
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.10.0
>
>
> This implies that calling {{FixedSizeBinaryBuilder::Append}} with a "const
> char*" argument currently instantiates a temporary {{std::string}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)