[
https://issues.apache.org/jira/browse/ARROW-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445192#comment-16445192
]
ASF GitHub Bot commented on ARROW-2435:
---------------------------------------
andygrove commented on issue #1875: ARROW-2435: [Rust] Add memory pool
abstraction.
URL: https://github.com/apache/arrow/pull/1875#issuecomment-382953309
I commented on the JIRA but will comment here too.
We now have two different memory implementations but only one is actually
used.
Also my original code has libc calls scattered around instead of being
isolated in one file, which isn't good and has also meant having to deal
with Windows in multiple places instead of just in the memory related
source files.
I'm looking at this now to try and figure out what we should do. I think we
will just want to use Rust's allocator API anyway once that becomes stable
so I'm not sure we really need a pluggable memory pool but I guess we can
have that discussion later.
I'm thinking I should at least submit a PR to move all the current memory
handling into the memory.rs file.
On Thu, Apr 19, 2018 at 8:07 PM, Renjie Liu <notificati...@github.com>
wrote:
> Hi @paddyhoran <https://github.com/paddyhoran>,
> in fact these are conventions inherited from allocator api, and here are
> my thoughts:
>
> - when you allocate a new piece of memory, in most cases it's used for
> storing data, and you need to write to it.
> - usize is a type designed for size and it has different length in
> different platforms for the sake of efficiency. If you use i64 in 32-bit
> platforms, it may be wasteful and hurt performance.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/arrow/pull/1875#issuecomment-382943494>, or mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AA5AxJ5mPMV-2J42RGhcF6Yc-LK6HacSks5tqULcgaJpZM4TN3tE>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Rust] Add memory pool abstraction.
> -----------------------------------
>
> Key: ARROW-2435
> URL: https://issues.apache.org/jira/browse/ARROW-2435
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Rust
> Affects Versions: 0.9.0
> Reporter: Renjie Liu
> Assignee: Renjie Liu
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.10.0
>
>
> Add memory pool abstraction as the c++ api.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
