[ 
https://issues.apache.org/jira/browse/ARROW-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445647#comment-16445647
 ] 

ASF GitHub Bot commented on ARROW-2435:
---------------------------------------

paddyhoran commented on issue #1875: ARROW-2435: [Rust] Add memory pool 
abstraction.
URL: https://github.com/apache/arrow/pull/1875#issuecomment-383077465
 
 
   @liurenjie1024 ok.  I'll take a look at this when I get a chance.  Right now 
though I'm going to see if I can conditionally compile this to get 
[ARROW-2474](https://issues.apache.org/jira/browse/ARROW-2474?filter=12343557) 
done.  The memory pool abstraction is not used anywhere within the codebase and 
with the fix I am proposing would not be available on windows.  I'll open a new 
JIRA to track the refactor work.
   
   @andygrove are you ok with this?  I know this is not a best practice and I 
would not want to get into the habit of doing this, I just want to get windows 
building again so I can work on windows CI.  Given that we are not sure how the 
allocator API will impact the need for a memory pool I think it's ok in this 
situation?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Rust] Add memory pool abstraction.
> -----------------------------------
>
>                 Key: ARROW-2435
>                 URL: https://issues.apache.org/jira/browse/ARROW-2435
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Rust
>    Affects Versions: 0.9.0
>            Reporter: Renjie Liu
>            Assignee: Renjie Liu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.10.0
>
>
> Add memory pool abstraction as the c++ api.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to