[ 
https://issues.apache.org/jira/browse/ARROW-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445237#comment-16445237
 ] 

ASF GitHub Bot commented on ARROW-2435:
---------------------------------------

paddyhoran commented on issue #1875: ARROW-2435: [Rust] Add memory pool 
abstraction.
URL: https://github.com/apache/arrow/pull/1875#issuecomment-382962137
 
 
   @liurenjie1024 thanks.  
   
   I was looking at the C++ implementation for reference:
    - I see that we basically do a reinterpret_cast before using the `*const 
u8` version.
    - I thought that `usize` is really for pointers, in the C++ implementation 
they use i64 for size
   
   How do you feel about refactoring this implementation to use the functions 
in `memory.rs` once @andygrove's PR above is merged?
   
   I'm having trouble adding windows support and it's not used anywhere else in 
the codebase...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Rust] Add memory pool abstraction.
> -----------------------------------
>
>                 Key: ARROW-2435
>                 URL: https://issues.apache.org/jira/browse/ARROW-2435
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Rust
>    Affects Versions: 0.9.0
>            Reporter: Renjie Liu
>            Assignee: Renjie Liu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.10.0
>
>
> Add memory pool abstraction as the c++ api.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to