clebertsuconic commented on code in PR #6323:
URL: https://github.com/apache/artemis/pull/6323#discussion_r3047567911


##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPStandardMessage.java:
##########
@@ -237,79 +238,10 @@ public void reloadPersistence(ActiveMQBuffer record, 
CoreMessageObjectPools pool
 
       // Message state is now that the underlying buffer is loaded, but the 
contents not yet scanned
       resetMessageData();
-      recoverHeaderDataFromEncoding();
+      scanMessageData(data);

Review Comment:
   @tabish121 I need to find the applicationProperties size and many messages 
it has. I don't think there's a way to find just that.
   
   The overhead on start, as I clear remember,  was definitely caused by the 
under-estimation of the message size. A server would die out of OME, and during 
restart the server was taking forever to start and it was actually because a 
lot of pressure was being added on the memory. I remember the case that brought 
to this change back then.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to