clebertsuconic commented on code in PR #6323:
URL: https://github.com/apache/artemis/pull/6323#discussion_r3047675595


##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java:
##########
@@ -759,6 +743,44 @@ protected synchronized void scanMessageData(ReadableBuffer 
data) {
       this.messageDataScanned = MessageDataScanningStatus.SCANNED.code;
    }
 
+   public int getApplicationPropertiesCount() {
+      ensureScanning();
+      return applicationPropertiesCount;
+   }
+
+
+   // this is "borrowed" from:
+   // 
https://github.com/apache/qpid-proton-j/blob/6dc5587f1d1b23969a8994f1755198e638e92bc4/proton-j/src/main/java/org/apache/qpid/proton/codec/messaging/FastPathApplicationPropertiesType.java#L93-L115

Review Comment:
   This is doing the same validation thst was being done before. 
   
   If you follow the previous call all cobstructor.skipvalue does is read the 
value and move the bytes. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to