[
https://issues.apache.org/jira/browse/ARTEMIS-5573?focusedWorklogId=1015506&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1015506
]
ASF GitHub Bot logged work on ARTEMIS-5573:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/26 15:30
Start Date: 14/Apr/26 15:30
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #6323:
URL: https://github.com/apache/artemis/pull/6323#discussion_r3080294163
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java:
##########
@@ -1220,13 +1233,18 @@ public final Object getDuplicateProperty() {
@Override
public boolean isDurable() {
- if (header != null && header .getDurable() != null) {
- return header.getDurable();
- } else {
- // if header == null and scanningStatus=RELOAD_PERSISTENCE, it means
the message can only be durable
- // even though the parsing hasn't happened yet
- return getDataScanningStatus() ==
MessageDataScanningStatus.RELOAD_PERSISTENCE;
+ if (this.durable == VALUE_NOT_PRESENT) {
+ if (header != null && header.getDurable() != null) {
+ this.durable = header.getDurable() ? (byte)1 : (byte)0;
Review Comment:
The side effects seem ugly and brittle, but _reloadSetDurable_ does this
same thing, and _setDurable_ calls that method below, so its unclear this
shouldnt also call it..
Issue Time Tracking
-------------------
Worklog Id: (was: 1015506)
Time Spent: 10h 50m (was: 10h 40m)
> Make AMQP Size immutable
> ------------------------
>
> Key: ARTEMIS-5573
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5573
> Project: Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.41.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10h 50m
> Remaining Estimate: 0h
>
> I have had a lot of issues, even recently on races between re-evaluating a
> message size in AMQP.
> Say a lazy decode happens at the wrong time and the memory estimates can be
> wrong.
> We have fixed issues along the years, but this is still a fragile process
> that is bound to fail. If an user for instance add a plugin breaking the
> chain of events.
> For that reason the memory estimate should already include enough estimation
> for any properties decoded and the process should be simplified.
> Less moving parts would mean less possibilities for bugs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
