[
https://issues.apache.org/jira/browse/ARTEMIS-5573?focusedWorklogId=1015794&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1015794
]
ASF GitHub Bot logged work on ARTEMIS-5573:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Apr/26 20:36
Start Date: 15/Apr/26 20:36
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #6323:
URL: https://github.com/apache/artemis/pull/6323#discussion_r3089203199
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPStandardMessage.java:
##########
@@ -198,8 +198,10 @@ public synchronized int getMemoryEstimate() {
private int getApplicationPropertiesEncodingSize(ReadableBuffer data) {
ensureScanning();
- // ensureScanning will make sure we know the positions, and we will
return the encoding used based on those positions
- if (remainingBodyPosition != VALUE_NOT_PRESENT) {
+ // if still VALUE_NOT_PRESENT, it means we have no application
properties, we must return 0
+ if (applicationPropertiesPosition == VALUE_NOT_PRESENT) {
+ return 0;
+ } else if (remainingBodyPosition != VALUE_NOT_PRESENT) {
return remainingBodyPosition - applicationPropertiesPosition;
} else if (applicationPropertiesPosition != VALUE_NOT_PRESENT) {
Review Comment:
Since the first if checks if `applicationPropertiesPosition ==
VALUE_NOT_PRESENT` the final else in this conditional is unreachable and you
can remove it and just have the `return data.capacity() -
applicationPropertiesPosition;` as the final else case.
Issue Time Tracking
-------------------
Worklog Id: (was: 1015794)
Time Spent: 12h 20m (was: 12h 10m)
> Make AMQP Size immutable
> ------------------------
>
> Key: ARTEMIS-5573
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5573
> Project: Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.41.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Time Spent: 12h 20m
> Remaining Estimate: 0h
>
> I have had a lot of issues, even recently on races between re-evaluating a
> message size in AMQP.
> Say a lazy decode happens at the wrong time and the memory estimates can be
> wrong.
> We have fixed issues along the years, but this is still a fragile process
> that is bound to fail. If an user for instance add a plugin breaking the
> chain of events.
> For that reason the memory estimate should already include enough estimation
> for any properties decoded and the process should be simplified.
> Less moving parts would mean less possibilities for bugs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
