[
https://issues.apache.org/jira/browse/AURORA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538139#comment-14538139
]
Maxim Khutornenko commented on AURORA-1282:
-------------------------------------------
This is potentially a breaking change for anyone currently using SLA stats to
monitor production health and requires broader announcement and possibly a
deprecation cycle. I am also not convinced
{{sla_testcluster_test_myservice_mttr_nonprod_ms}} is easier to read than
{{sla_testcluster/test/myservice_mttr_nonprod_ms}} especially when it comes to
multi-word role/job names. What's the downside of using non-normalized names?
Should we rather drop the warning in commons?
https://github.com/twitter/commons/blob/afbca0b5ded2d6cf2d918bd0d7c85e43dc9919cf/src/java/com/twitter/common/stats/Stats.java#L71
> twitter.common.stats.Stats warns about exported metric names
> ------------------------------------------------------------
>
> Key: AURORA-1282
> URL: https://issues.apache.org/jira/browse/AURORA-1282
> Project: Aurora
> Issue Type: Bug
> Reporter: Stephan Erb
> Assignee: Joe Smith
> Priority: Minor
>
> The Aurora log file gets spammed with lots of warnings for each service/job:
> {code}
> W0417 11:10:06.046 THREAD159 com.twitter.common.stats.Stats.validateName:
> Invalid stat name sla_testcluster/test/myservice_mttr_nonprod_ms exported as
> sla_testcluster_test_myservice_mttr_nonprod_ms
> {code}
> Any proposals how we might get rid of them or silence them?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
