[ 
https://issues.apache.org/jira/browse/AURORA-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644660#comment-14644660
 ] 

Bill Farner commented on AURORA-1282:
-------------------------------------

As with a lot of magic, it's all an act of misdirection :-)

You see slashes because the vars printer \[1\] does not read (or even have 
access to) the normalized name, and the {{Stats.STATS_PROVIDER.untracked()}} 
entry-point we use for SLA stats internally uses {{Stats.exportStatic()}}, 
which appears to have a bug in that it does not wrap the provided {{Stat}} 
instance to replace the name with the normalized one it puts in 
{{Stats.VAR_MAP}}.  In fact, {{Stats.VAR_MAP}} (the only place the normalized 
names go) is not exposed anywhere.

That was pretty awkward to try to explain in prose, but if you approach from 
{{untracked()}}, and then from {{VarsHandler.getLines()}}, you should spot the 
impedance mismatch.

\[1\] 
https://github.com/twitter/commons/blob/170192210e4588cff99e8b3560cf2461ca55778f/src/java/com/twitter/common/net/http/handlers/VarsHandler.java#L58-L63


> twitter.common.stats.Stats warns about exported metric names
> ------------------------------------------------------------
>
>                 Key: AURORA-1282
>                 URL: https://issues.apache.org/jira/browse/AURORA-1282
>             Project: Aurora
>          Issue Type: Bug
>            Reporter: Stephan Erb
>            Assignee: Joe Smith
>            Priority: Minor
>
> The Aurora log file gets spammed with lots of warnings for each service/job: 
> {code}
> W0417 11:10:06.046 THREAD159 com.twitter.common.stats.Stats.validateName: 
> Invalid stat name sla_testcluster/test/myservice_mttr_nonprod_ms exported as 
> sla_testcluster_test_myservice_mttr_nonprod_ms
> {code}
> Any proposals how we might get rid of them or silence them?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to