opwvhk commented on a change in pull request #1381:
URL: https://github.com/apache/avro/pull/1381#discussion_r774371722



##########
File path: 
lang/java/avro/src/test/java/org/apache/avro/io/parsing/TestResolvingGrammarGenerator.java
##########
@@ -83,6 +83,21 @@ public void testRecordMissingRequiredFieldError() throws 
Exception {
     }
   }
 
+  @Test
+  public void testDifferingEnumNamespaces() throws Exception {
+    Schema enumSchema1 = 
SchemaBuilder.builder().enumeration("Enum").namespace("namespace1").symbols("Symbol1",
+        "Symbol2");
+    Schema enumSchema2 = 
SchemaBuilder.builder().enumeration("Enum").namespace("namespace2").symbols("Symbol1",
+        "Symbol2");

Review comment:
       Can we use schema constants from `TestSchemas` here? Then we can do 
compatibility checks using the same schemas.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to