opwvhk commented on a change in pull request #1381:
URL: https://github.com/apache/avro/pull/1381#discussion_r774519773
##########
File path:
lang/java/avro/src/test/java/org/apache/avro/TestSchemaCompatibility.java
##########
@@ -260,6 +261,10 @@ public void testUnionReaderWriterSubsetIncompatibility() {
new ReaderWriter(ENUM1_AB_SCHEMA, ENUM1_AB_SCHEMA), new
ReaderWriter(ENUM1_ABC_SCHEMA, ENUM1_AB_SCHEMA),
+ new ReaderWriter(ENUM1_AB_SCHEMA, ENUM1_AB_SCHEMA),
+
+ new ReaderWriter(ENUM1_AB_SCHEMA, ENUM1_AB_SCHEMA_NAMESPACE),
Review comment:
This tests the new functionality, but not completely IMHO. Shouldn't we
also test these?
* `new ReaderWriter(ENUM1_AB_SCHEMA_NAMESPACE, ENUM1_AB_SCHEMA)`
* `new ReaderWriter(ENUM1_AB_SCHEMA_NAMESPACE2, ENUM1_AB_SCHEMA_NAMESPACE)`
I think we should at least have the first of these. Or does the test in line
266 test the same thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
