opwvhk commented on a change in pull request #1381:
URL: https://github.com/apache/avro/pull/1381#discussion_r778732828
##########
File path:
lang/java/avro/src/test/java/org/apache/avro/io/parsing/TestResolvingGrammarGenerator.java
##########
@@ -85,13 +88,9 @@ public void testRecordMissingRequiredFieldError() throws
Exception {
@Test
public void testDifferingEnumNamespaces() throws Exception {
- Schema enumSchema1 =
SchemaBuilder.builder().enumeration("Enum").namespace("namespace1").symbols("Symbol1",
- "Symbol2");
- Schema enumSchema2 =
SchemaBuilder.builder().enumeration("Enum").namespace("namespace2").symbols("Symbol1",
- "Symbol2");
- Schema schema1 =
SchemaBuilder.record("MyRecord").fields().name("field").type(enumSchema1).noDefault().endRecord();
- Schema schema2 =
SchemaBuilder.record("MyRecord").fields().name("field").type(enumSchema2).noDefault().endRecord();
- GenericData.EnumSymbol genericEnumSymbol = new
GenericData.EnumSymbol(enumSchema1, "Symbol1");
+ Schema schema1 =
SchemaBuilder.record("MyRecord").fields().name("field").type(ENUM1_AB_SCHEMA_NAMESPACE_1).noDefault().endRecord();
+ Schema schema2 =
SchemaBuilder.record("MyRecord").fields().name("field").type(ENUM1_AB_SCHEMA_NAMESPACE_2).noDefault().endRecord();
+ GenericData.EnumSymbol genericEnumSymbol = new
GenericData.EnumSymbol(ENUM1_AB_SCHEMA_NAMESPACE_1, "A");
Review comment:
Nicely clean :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
