[
https://issues.apache.org/jira/browse/BEAM-5675?focusedWorklogId=157227&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-157227
]
ASF GitHub Bot logged work on BEAM-5675:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/18 21:53
Start Date: 22/Oct/18 21:53
Worklog Time Spent: 10m
Work Description: reuvenlax commented on issue #6772: [BEAM-5675] Fix
RowCoder#verifyDeterministic
URL: https://github.com/apache/beam/pull/6772#issuecomment-431997655
Yes we can revert. Which unit tests fail? The presubmit on the PR appeared
green when I merged it.
On Mon, Oct 22, 2018 at 2:35 PM amaliujia <[email protected]> wrote:
> @kanterov <https://github.com/kanterov> @reuvenlax
> <https://github.com/reuvenlax>
>
> Seems like this PR introduced failures to some unit tests. Would you mind
> reverting this PR or submitting a fix to it?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/6772#issuecomment-431997022>, or mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AUGE1cbF9WB5RRqpYCeaycKaD8h4Unkuks5unjoagaJpZM4XzAf_>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 157227)
Time Spent: 2h 10m (was: 2h)
> RowCoder#verifyDeterministic isn't consistent with Beam coders
> --------------------------------------------------------------
>
> Key: BEAM-5675
> URL: https://issues.apache.org/jira/browse/BEAM-5675
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Affects Versions: 2.7.0
> Reporter: Gleb Kanterov
> Assignee: Gleb Kanterov
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> For instance, `DoubleCoder#verifyDeterministic` throws an exception, but
> `RowCoder#verifyDeterministic` doesn't.
> Expected to throw NonDeterministicException
> {code:java}
> RowCoder.of(
> Schema
> .builder()
> .addField("foo", Schema.FieldType.DOUBLE)
> .build()
> ).verifyDeterministic();
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
