[ 
https://issues.apache.org/jira/browse/BEAM-5675?focusedWorklogId=157248&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-157248
 ]

ASF GitHub Bot logged work on BEAM-5675:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Oct/18 22:05
            Start Date: 22/Oct/18 22:05
    Worklog Time Spent: 10m 
      Work Description: kennknowles commented on issue #6772: [BEAM-5675] Fix 
RowCoder#verifyDeterministic
URL: https://github.com/apache/beam/pull/6772#issuecomment-432004776
 
 
   So actually, who knows if any engine actually implements it in a consistent 
way. In which case, letting the query through is just doing the user a 
disservice.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 157248)
    Time Spent: 4h  (was: 3h 50m)

> RowCoder#verifyDeterministic isn't consistent with Beam coders
> --------------------------------------------------------------
>
>                 Key: BEAM-5675
>                 URL: https://issues.apache.org/jira/browse/BEAM-5675
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql
>    Affects Versions: 2.7.0
>            Reporter: Gleb Kanterov
>            Assignee: Gleb Kanterov
>            Priority: Major
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> For instance, `DoubleCoder#verifyDeterministic` throws an exception, but 
> `RowCoder#verifyDeterministic` doesn't.
> Expected to throw NonDeterministicException
> {code:java}
> RowCoder.of(
>     Schema
>         .builder()
>         .addField("foo", Schema.FieldType.DOUBLE)
>         .build()
> ).verifyDeterministic();
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to