[
https://issues.apache.org/jira/browse/BEAM-5675?focusedWorklogId=157239&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-157239
]
ASF GitHub Bot logged work on BEAM-5675:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/18 22:02
Start Date: 22/Oct/18 22:02
Worklog Time Spent: 10m
Work Description: reuvenlax commented on issue #6772: [BEAM-5675] Fix
RowCoder#verifyDeterministic
URL: https://github.com/apache/beam/pull/6772#issuecomment-432003130
@kanterov unfortunately Beam SQL seems to rely on the ability to put
floating-point values in keys. Could you roll back this PR until that is sorted
out? Sorry this wasn't caught before, as presubmits were apparently not running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 157239)
Time Spent: 2h 50m (was: 2h 40m)
> RowCoder#verifyDeterministic isn't consistent with Beam coders
> --------------------------------------------------------------
>
> Key: BEAM-5675
> URL: https://issues.apache.org/jira/browse/BEAM-5675
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Affects Versions: 2.7.0
> Reporter: Gleb Kanterov
> Assignee: Gleb Kanterov
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> For instance, `DoubleCoder#verifyDeterministic` throws an exception, but
> `RowCoder#verifyDeterministic` doesn't.
> Expected to throw NonDeterministicException
> {code:java}
> RowCoder.of(
> Schema
> .builder()
> .addField("foo", Schema.FieldType.DOUBLE)
> .build()
> ).verifyDeterministic();
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
